This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Use std::list instead of std::map for factory instance #16161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshalamov
force-pushed
the
alexshalamov_fix_recursive_factory
branch
from
13202e9
to
5af2925
Compare
pozdnyakov
reviewed
Feb 3, 2020
alexshalamov
force-pushed
the
alexshalamov_fix_recursive_factory
branch
from
5af2925
to
0dc1fc4
Compare
pozdnyakov
approved these changes
Feb 3, 2020
alexshalamov
force-pushed
the
alexshalamov_fix_recursive_factory
branch
from
0dc1fc4
to
03c4950
Compare
Factory 'get' method can be invoked recursively and stable iterators are required to guarantee safety.
alexshalamov
force-pushed
the
alexshalamov_fix_recursive_factory
branch
from
03c4950
to
fc1a139
Compare
This was referenced Feb 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factory 'get' method can be invoked recursively and stable iterators are required to guarantee safety.
Launch Checklist
needs changeloglabel if a changelog is needed (remove label when added)